]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt_en: Fix unnecessary dropping of RX packets
authorMichael Chan <michael.chan@broadcom.com>
Tue, 3 May 2022 01:13:12 +0000 (21:13 -0400)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 May 2022 00:41:32 +0000 (17:41 -0700)
commitbcd2948f1818351e062f74050813e19cb1ac45fd
treeb6d88882a7cbd2749d2e6e307e5eb9eb94501dd9
parente8e3e235315a3efbb7491304e935f88bebde6bcc
bnxt_en: Fix unnecessary dropping of RX packets

In bnxt_poll_p5(), we first check cpr->has_more_work.  If it is true,
we are in NAPI polling mode and we will call __bnxt_poll_cqs() to
continue polling.  It is possible to exhanust the budget again when
__bnxt_poll_cqs() returns.

We then enter the main while loop to check for new entries in the NQ.
If we had previously exhausted the NAPI budget, we may call
__bnxt_poll_work() to process an RX entry with zero budget.  This will
cause packets to be dropped unnecessarily, thinking that we are in the
netpoll path.  Fix it by breaking out of the while loop if we need
to process an RX NQ entry with no budget left.  We will then exit
NAPI and stay in polling mode.

Fixes: a59609188f70 ("bnxt_en: Process the NQ under NAPI continuous polling.")
Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c