]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: fix a potential oops
authorYing Xue <ying.xue@windriver.com>
Thu, 28 Aug 2014 02:02:41 +0000 (10:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Aug 2014 03:22:43 +0000 (20:22 -0700)
commitbca949e9d23e5010f15cc1d5ba7c1b34aad43fd1
treef8c0f6ddc1da64e55a483d097df168571a560f14
parent1ece55b9d4d47163539211c5896215180eca39e8
tipc: fix a potential oops

Commit 634b7fce81b7 ("tipc: remove port_lock") accidentally involves
a potential bug: when tipc socket instance(tsk) is not got with given
reference number in tipc_sk_get(), tsk is set to NULL. Subsequently
we jump to exit label where to decrease socket reference counter
pointed by tsk pointer in tipc_sk_put(). However, As now tsk is NULL,
oops may happen because of touching a NULL pointer.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Erik Hugne <erik.hugne@ericsson.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c