]> git.baikalelectronics.ru Git - kernel.git/commit
net: qrtr: start MHI channel after endpoit creation
authorMaxim Kochetkov <fido_max@inbox.ru>
Thu, 11 Aug 2022 09:48:40 +0000 (12:48 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Aug 2022 10:21:42 +0000 (11:21 +0100)
commitbc890233c084c65f34b0845360c57c17819ae12e
tree0a81105de24c9d2e3fbd246a4e3e3657848e14e1
parent98852c7f13616d07f18a35cddde9522624c21acb
net: qrtr: start MHI channel after endpoit creation

MHI channel may generates event/interrupt right after enabling.
It may leads to 2 race conditions issues.

1)
Such event may be dropped by qcom_mhi_qrtr_dl_callback() at check:

if (!qdev || mhi_res->transaction_status)
return;

Because dev_set_drvdata(&mhi_dev->dev, qdev) may be not performed at
this moment. In this situation qrtr-ns will be unable to enumerate
services in device.
---------------------------------------------------------------

2)
Such event may come at the moment after dev_set_drvdata() and
before qrtr_endpoint_register(). In this case kernel will panic with
accessing wrong pointer at qcom_mhi_qrtr_dl_callback():

rc = qrtr_endpoint_post(&qdev->ep, mhi_res->buf_addr,
mhi_res->bytes_xferd);

Because endpoint is not created yet.
--------------------------------------------------------------
So move mhi_prepare_for_transfer_autoqueue after endpoint creation
to fix it.

Fixes: ce8f51e3e876 ("net: qrtr: Start MHI channels during init")
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Hemant Kumar <quic_hemantk@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/mhi.c