]> git.baikalelectronics.ru Git - kernel.git/commit
x86-32, vdso: Fix vDSO build error due to missing align_vdso_addr()
authorJan Beulich <JBeulich@suse.com>
Thu, 3 Jul 2014 14:35:07 +0000 (15:35 +0100)
committerH. Peter Anvin <hpa@linux.intel.com>
Thu, 10 Jul 2014 23:06:04 +0000 (16:06 -0700)
commitbc7623363d2cac34d7af540405faf157dc71b447
tree3893d95782be8f751f9aef7406e14d82ca832af1
parent53da421c21dc4ae6fb5693160ea470bd00490944
x86-32, vdso: Fix vDSO build error due to missing align_vdso_addr()

Relying on static functions used just once to get inlined (and
subsequently have dead code paths eliminated) is wrong: Compilers are
free to decide whether they do this, regardless of optimization level.
With this not happening for vdso_addr() (observed with gcc 4.1.x), an
unresolved reference to align_vdso_addr() causes the build to fail.

[ hpa: vdso_addr() is never actually used on x86-32, as calculate_addr
  in map_vdso() is always false.  It ought to be possible to clean
  this up further, but this fixes the immediate problem. ]

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Link: http://lkml.kernel.org/r/53B5863B02000078000204D5@mail.emea.novell.com
Acked-by: Andy Lutomirski <luto@amacapital.net>
Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Tested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
arch/x86/vdso/vma.c