]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: uprobes: remove incorrect set_orig_insn
authorMarcin Nowakowski <marcin.nowakowski@imgtec.com>
Thu, 22 Sep 2016 13:38:32 +0000 (15:38 +0200)
committerRalf Baechle <ralf@linux-mips.org>
Thu, 29 Sep 2016 16:59:49 +0000 (18:59 +0200)
commitbb7b263de68b40156bd37c371eb9a33db584383e
tree822ba923abc3cc07492ddc4d4465e74ae500fff9
parent99abeb39cf2f6254c929825a4b4b17a6881902db
MIPS: uprobes: remove incorrect set_orig_insn

Generic kernel code implements a weak version of set_orig_insn that
moves cached 'insn' from arch_uprobe to the original code location when
the trap is removed.
MIPS variant used arch_uprobe->orig_inst which was never initialised
properly, so this code only inserted a nop instead of the original
instruction. With that change orig_inst can also be safely removed.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Fixes: 0198f2262f70 ('MIPS: Add uprobes support.')
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14299/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/include/asm/uprobes.h
arch/mips/kernel/uprobes.c