]> git.baikalelectronics.ru Git - kernel.git/commit
mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
authorH. Peter Anvin <hpa@zytor.com>
Tue, 8 Dec 2009 22:01:32 +0000 (14:01 -0800)
committerH. Peter Anvin <hpa@zytor.com>
Fri, 11 Dec 2009 23:27:47 +0000 (15:27 -0800)
commitb925585039cf39275c2e0e57512e5df27fa73aad
tree1e264b4e3470013aabc10c27bf5054729b5b269f
parent2eaad1fddd7450a48ad464229775f97fbfe8af36
mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe

Slightly adjust the logic for determining the size of the
copy_form_user() in do_pages_stat(); with this change, gcc can see
that the copying is safe.

Without this, we get a build error for i386 allyesconfig:

/home/hpa/kernel/linux-2.6-tip.urgent/arch/x86/include/asm/uaccess_32.h:213:
error: call to ‘copy_from_user_overflow’ declared with attribute
error: copy_from_user() buffer size is not provably correct

Unlike an earlier patch from Arjan, this doesn't introduce new
variables; merely reshuffles the compare so that gcc can see that an
overflow cannot happen.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Brice Goglin <Brice.Goglin@inria.fr>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
LKML-Reference: <20090926205406.30d55b08@infradead.org>
mm/migrate.c