]> git.baikalelectronics.ru Git - kernel.git/commit
net: macb: Increment rx bd head after allocating skb and buffer
authorHarini Katakam <harini.katakam@xilinx.com>
Thu, 12 May 2022 17:19:00 +0000 (22:49 +0530)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 May 2022 00:09:02 +0000 (17:09 -0700)
commitb8a8d6b5a8f3ed8880a48afc6ce4a89f0e454c7c
tree7a744cded1d6f1ebc572668510bb954adfe33ce2
parentd5b483a8211c9e819e70a3af1a7ebe4d65de5fe8
net: macb: Increment rx bd head after allocating skb and buffer

In gem_rx_refill rx_prepared_head is incremented at the beginning of
the while loop preparing the skb and data buffers. If the skb or data
buffer allocation fails, this BD will be unusable BDs until the head
loops back to the same BD (and obviously buffer allocation succeeds).
In the unlikely event that there's a string of allocation failures,
there will be an equal number of unusable BDs and an inconsistent RX
BD chain. Hence increment the head at the end of the while loop to be
clean.

Fixes: e608a696d0ce ("net/macb: change RX path for GEM")
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20220512171900.32593-1-harini.katakam@xilinx.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c