]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5: Avoid double free in fs init error unwinding path
authorParav Pandit <parav@mellanox.com>
Fri, 10 May 2019 15:26:23 +0000 (10:26 -0500)
committerSaeed Mahameed <saeedm@mellanox.com>
Wed, 29 May 2019 01:25:41 +0000 (18:25 -0700)
commitb81c485484917a0c80d6ade62b7d717c9bfab83d
tree75e27f682502a9bb77f6181ac926714f93bada33
parent17f68958538178773cccda8d0435b16d39446c9c
net/mlx5: Avoid double free in fs init error unwinding path

In below code flow, for ingress acl table root ns memory leads
to double free.

mlx5_init_fs
  init_ingress_acls_root_ns()
    init_ingress_acl_root_ns
       kfree(steering->esw_ingress_root_ns);
       /* steering->esw_ingress_root_ns is not marked NULL */
  mlx5_cleanup_fs
    cleanup_ingress_acls_root_ns
       steering->esw_ingress_root_ns non NULL check passes.
       kfree(steering->esw_ingress_root_ns);
       /* double free */

Similar issue exist for other tables.

Hence zero out the pointers to not process the table again.

Fixes: 832c9df7260bb ("net/mlx5: Separate ingress/egress namespaces for each vport")
Fixes: 40c3eebb49e51 ("net/mlx5: Add support in RDMA RX steering")
Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c