]> git.baikalelectronics.ru Git - kernel.git/commit
tty_port,usb-console: Fix usb serial console open/close regression
authorJason Wessel <jason.wessel@windriver.com>
Tue, 9 Mar 2010 03:50:11 +0000 (21:50 -0600)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 19 Mar 2010 14:17:57 +0000 (07:17 -0700)
commitb80ffbb50590f886bbae00a5ad6dad4e346d8efa
tree893babf1f6804b35a944ac413d16f7107d922e14
parentfef414bdf950974e006e13633221e700c64b5457
tty_port,usb-console: Fix usb serial console open/close regression

Commit 4671eecf7b648641c1035a2e2cbba26f07a82e74 ("usb_serial: Use the
shutdown() operation") breaks the ability to use a usb console
starting in 2.6.33.  This was observed when using
console=ttyUSB0,115200 as a boot argument with an FTDI device.  The
error is:

ftdi_sio ttyUSB0: ftdi_submit_read_urb - failed submitting read urb, error -22

The handling of the ASYNCB_INITIALIZED changed in 2.6.32 such that in
tty_port_shutdown() it always clears the flag if it is set.  The fix
is to add a variable to the tty_port struct to indicate when the tty
port is a console.

CC: Alan Cox <alan@linux.intel.com>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Oliver Neukum <oliver@neukum.org>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/tty_port.c
drivers/usb/serial/console.c
include/linux/tty.h