]> git.baikalelectronics.ru Git - kernel.git/commit
i40e: improve locking of mac_filter_hash
authorStefan Assmann <sassmann@kpanic.de>
Thu, 4 Mar 2021 09:34:30 +0000 (10:34 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 19 Jul 2021 16:18:30 +0000 (09:18 -0700)
commitb7c0ef288aa0c0b6ce9fcd47b0aeec11ae6a0914
tree12361330b03ef66edd3346cc0529a1755de2d1f7
parentb147d84579309bbc34be22e44daba385ea030be5
i40e: improve locking of mac_filter_hash

i40e_config_vf_promiscuous_mode() calls
i40e_getnum_vf_vsi_vlan_filters() without acquiring the
mac_filter_hash_lock spinlock.

This is unsafe because mac_filter_hash may get altered in another thread
while i40e_getnum_vf_vsi_vlan_filters() traverses the hashes.

Simply adding the spinlock in i40e_getnum_vf_vsi_vlan_filters() is not
possible as it already gets called in i40e_get_vlan_list_sync() with the
spinlock held. Therefore adding a wrapper that acquires the spinlock and
call the correct function where appropriate.

Fixes: 3ee8c710d51f ("i40e: Remove scheduling while atomic possibility")
Fix-suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c