]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: compress: Fix stop handling on compressed capture streams
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 5 Feb 2019 16:29:40 +0000 (16:29 +0000)
committerTakashi Iwai <tiwai@suse.de>
Tue, 5 Feb 2019 21:01:41 +0000 (22:01 +0100)
commitb72cc85efcadaac129348b0618e4f1b6ceeb71d2
tree96d40a5a86e2c2358d8aec9564af60e47164f709
parenta8da26145b4c2cbe7144661ea1941cd5b71a6624
ALSA: compress: Fix stop handling on compressed capture streams

It is normal user behaviour to start, stop, then start a stream
again without closing it. Currently this works for compressed
playback streams but not capture ones.

The states on a compressed capture stream go directly from OPEN to
PREPARED, unlike a playback stream which moves to SETUP and waits
for a write of data before moving to PREPARED. Currently however,
when a stop is sent the state is set to SETUP for both types of
streams. This leaves a capture stream in the situation where a new
start can't be sent as that requires the state to be PREPARED and
a new set_params can't be sent as that requires the state to be
OPEN. The only option being to close the stream, and then reopen.

Correct this issues by allowing snd_compr_drain_notify to set the
state depending on the stream direction, as we already do in
set_params.

Fixes: fab9316f278a ("ALSA: compress_core: Add support for capture streams")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/compress_driver.h