]> git.baikalelectronics.ru Git - kernel.git/commit
Drivers: hv: vmbus: Prevent load re-ordering when reading ring buffer
authorMichael Kelley <mikelley@microsoft.com>
Sun, 27 Mar 2022 15:25:10 +0000 (08:25 -0700)
committerWei Liu <wei.liu@kernel.org>
Tue, 29 Mar 2022 13:19:33 +0000 (13:19 +0000)
commitb6cae15b5710c8097aad26a2e5e752c323ee5348
tree677c5a8ddd9fef4555615dc6373b702ad06c38db
parent8d21732475c637c7efcdb91dc927a4c594e97898
Drivers: hv: vmbus: Prevent load re-ordering when reading ring buffer

When reading a packet from a host-to-guest ring buffer, there is no
memory barrier between reading the write index (to see if there is
a packet to read) and reading the contents of the packet. The Hyper-V
host uses store-release when updating the write index to ensure that
writes of the packet data are completed first. On the guest side,
the processor can reorder and read the packet data before the write
index, and sometimes get stale packet data. Getting such stale packet
data has been observed in a reproducible case in a VM on ARM64.

Fix this by using virt_load_acquire() to read the write index,
ensuring that reads of the packet data cannot be reordered
before it. Preventing such reordering is logically correct, and
with this change, getting stale data can no longer be reproduced.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Reviewed-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Link: https://lore.kernel.org/r/1648394710-33480-1-git-send-email-mikelley@microsoft.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/ring_buffer.c