]> git.baikalelectronics.ru Git - kernel.git/commit
rbd: silence bogus uninitialized warning in rbd_object_map_update_finish()
authorIlya Dryomov <idryomov@gmail.com>
Wed, 13 Nov 2019 11:07:15 +0000 (12:07 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 14 Nov 2019 18:00:53 +0000 (19:00 +0100)
commitb5d4de73d0f0ff7743855fea8c74fff3dea1c373
tree61b7c274cf27a630b78d8b81e35f7b09cea06aed
parent68b4483ae8786e953b8b7f7d970d124b202a2b58
rbd: silence bogus uninitialized warning in rbd_object_map_update_finish()

Some versions of gcc (so far 6.3 and 7.4) throw a warning:

  drivers/block/rbd.c: In function 'rbd_object_map_callback':
  drivers/block/rbd.c:2124:21: warning: 'current_state' may be used uninitialized in this function [-Wmaybe-uninitialized]
        (current_state == OBJECT_EXISTS && state == OBJECT_EXISTS_CLEAN))
  drivers/block/rbd.c:2092:23: note: 'current_state' was declared here
    u8 state, new_state, current_state;
                          ^~~~~~~~~~~~~

It's bogus because all current_state accesses are guarded by
has_current_state.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
drivers/block/rbd.c