]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Reject set-tiling-ioctl with stride==0 and a tiling mode
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 3 Feb 2017 10:56:52 +0000 (10:56 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 3 Feb 2017 13:03:07 +0000 (13:03 +0000)
commitb5d3e74797fdaeb7dd1abb12e03255e91f32fc0e
tree319f3bc9989b77226f64515f560a71447be47020
parentedea95600b4a30703f00b322301d9b97a70a455a
drm/i915: Reject set-tiling-ioctl with stride==0 and a tiling mode

In commit 9e25dc1b764a ("drm/i915: Split out i915_gem_object_set_tiling()"),
I swapped an alignment check for IS_ALIGNED and in the process removed
the less-than check. That check turns out to be important as it was the
only rejection for stride == 0. Tvrtko did spot it, but I was
overconfident in the IS_ALIGNED() conversion.

Fixes: 9e25dc1b764a ("drm/i915: Split out i915_gem_object_set_tiling()")
Testcase: igt/gem_tiling_max_stride
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170203105652.27819-1-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/i915_gem_tiling.c