]> git.baikalelectronics.ru Git - kernel.git/commit
[JFFS2] Fix free space leak with in-band cleanmarkers
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 22 Apr 2008 22:54:38 +0000 (23:54 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Tue, 22 Apr 2008 22:54:38 +0000 (23:54 +0100)
commitb51267b2cabb90faf95aee51503b276be9082294
treefec4eb1a16160e3b16faa567e0fa8bcb2cb21607
parent9506fc3443906e787e978b309b1ea39126803d25
[JFFS2] Fix free space leak with in-band cleanmarkers

We were accounting for the cleanmarker by calling jffs2_link_node_ref()
(without locking!), which adjusted both superblock and per-eraseblock
accounting, subtracting the size of the cleanmarker from {jeb,c}->free_size
and adding it to {jeb,c}->used_size.

But only _then_ were we adding the size of the newly-erased block back
to the superblock counts, and we were adding each of jeb->{free,used}_size
to the corresponding superblock counts. Thus, the size of the cleanmarker
was effectively subtracted from the superblock's free_size _twice_.

Fix this, by always adding a full eraseblock size to c->free_size when
we've erased a block. And call jffs2_link_node_ref() under the proper
lock, while we're at it.

Thanks to Alexander Yurchenko and/or Damir Shayhutdinov for (almost)
pinpointing the problem.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
fs/jffs2/erase.c