]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sun4i: backend: add missing of_node_puts
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 13 Jan 2019 08:47:44 +0000 (09:47 +0100)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Tue, 15 Jan 2019 20:46:10 +0000 (21:46 +0100)
commitb50c0751b5f47624895e78b0bcb56dd2e148c237
tree699b27b4ad9837f2df31dbd7cef644ca1cb4a45a
parent36619b4c37a2ebfde4b2b41f8c91d716be8a7af0
drm/sun4i: backend: add missing of_node_puts

The device node iterators perform an of_node_get on each
iteration, so a jump out of the loop requires an of_node_put.

Remote and port also have augmented reference counts, so drop them
on each iteration and at the end of the function, respectively.
Remote is only used for the address it contains, not for the
contents of that address, so the reference count can be dropped
immediately.

The semantic patch that fixes the first part of this problem is
as follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1547369264-24831-5-git-send-email-Julia.Lawall@lip6.fr
drivers/gpu/drm/sun4i/sun4i_backend.c