]> git.baikalelectronics.ru Git - kernel.git/commit
drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY
authorDavid Rivshin <drivshin@allworx.com>
Thu, 17 Dec 2015 04:02:10 +0000 (23:02 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Dec 2015 19:46:05 +0000 (14:46 -0500)
commitb483a653c129cadc8f4ed490788cbf51fc632a0e
treec2c7b0b3aeeb9410ac2dd1ef6c14055bd0e9c139
parentd72d06e14d9d7845f9fd536dfeab431cc007ebf3
drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

Commit ed0a34c16efb839d21b914b1576a1e927fcf9804 ("drivers: net: cpsw: Add
support for fixed-link PHY") did not parse the "phy-mode" property in
the case of a fixed-link PHY, leaving slave_data->phy_if with its default
of PHY_INTERFACE_MODE_NA(0). This later gets passed to phy_connect() in
cpsw_slave_open(), and eventually to cpsw_phy_sel() where it hits a default
case that configures the MAC for MII mode.

The user visible symptom is that while kernel log messages seem to indicate
that the interface is set up, there is no network communication. Eventually
a watchdog error occurs:
    NETDEV WATCHDOG: eth0 (cpsw): transmit queue 0 timed out

Fixes: ed0a34c16efb ("drivers: net: cpsw: Add support for fixed-link PHY")
Signed-off-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/cpsw.txt
drivers/net/ethernet/ti/cpsw.c