]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode
authorImre Deak <imre.deak@intel.com>
Tue, 29 Dec 2020 17:22:01 +0000 (19:22 +0200)
committerImre Deak <imre.deak@intel.com>
Wed, 13 Jan 2021 15:22:14 +0000 (17:22 +0200)
commitb457dc132ac23f515774e0b0975f7e97159fa223
tree7436b835c43712c4c1b2af8c4413e76019a4dc47
parent39389b8e4835865efd8dccaef9777f1c9d9fe9e8
drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode

The DP PHY vswing/pre-emphasis level programming the driver does is
related to the DPTX -> first LTTPR link segment only. Accordingly it
should be only programmed when link training the first LTTPR and kept
as-is when training subsequent LTTPRs and the DPRX. For these latter
PHYs the vs/pe levels will be set in response to writing the
DP_TRAINING_LANEx_SET_PHY_REPEATERy DPCD registers (by an upstream LTTPR
TX PHY snooping this write access of its downstream LTTPR/DPRX RX PHY).
The above is also described in DP Standard v2.0 under 3.6.6.1.

While at it simplify and add the LTTPR that is link trained to the debug
message in intel_dp_set_signal_levels().

Fixes: d3297d093260 ("drm/i915: Switch to LTTPR non-transparent mode link training")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201229172201.4155327-2-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp_link_training.c
drivers/gpu/drm/i915/display/intel_dp_link_training.h