]> git.baikalelectronics.ru Git - kernel.git/commit
net: ks8851: Remove ks8851_rdreg32()
authorMarek Vasut <marex@denx.de>
Thu, 28 May 2020 22:21:34 +0000 (00:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 May 2020 23:30:04 +0000 (16:30 -0700)
commitb3d8c1461b60069da9b2cac8898ca28421ebc456
tree4cc2b61714370a950ab86c3db8302ae0e28b7ff8
parentf1eae553e8d2d626d4d02851dda13e459243fb1d
net: ks8851: Remove ks8851_rdreg32()

The ks8851_rdreg32() is used only in one place, to read two registers
using a single read. To make it easier to support 16-bit accesses via
parallel bus later on, replace this single read with two 16-bit reads
from each of the registers and drop the ks8851_rdreg32() altogether.

If this has noticeable performance impact on the SPI variant of KS8851,
then we should consider using regmap to abstract the SPI and parallel
bus options and in case of SPI, permit regmap to merge register reads
of neighboring registers into single, longer, read.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ks8851.c