]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hdsp: Make the firmware loading ioctl a bit more readable
authorTakashi Iwai <tiwai@suse.de>
Sun, 2 Feb 2020 09:07:24 +0000 (10:07 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 2 Feb 2020 09:08:33 +0000 (10:08 +0100)
commitb3b3e4160dde8510645892a539c7127a4701f159
tree099e01cd31d44f3dfecdc5b1eb5551f50681b6e9
parent85af462c5ed37f797e9b2b6fd359b4dc7e86aabb
ALSA: hdsp: Make the firmware loading ioctl a bit more readable

The firmware loading ioctl that is implemented for hdsp hwdep device
takes the reference of the address pointer, hence the current code is
rather confusing.  Also, due to the recent change in uapi header,
sparse also complains about the cast.

This patch tries to improve the readability by converting the
straightforward copy_from_user of the whole struct (which contains
only the pointer).

Fixes: b4ffff7f1778 ("ALSA: hdsp: Make uapi/hdsp.h compilable again")
Link: https://lore.kernel.org/r/20200202090724.18232-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/rme9652/hdsp.c