]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "sched/wait: Suppress Sparse 'variable shadowing' warning"
authorIngo Molnar <mingo@kernel.org>
Thu, 27 Feb 2014 11:20:31 +0000 (12:20 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 27 Feb 2014 11:20:31 +0000 (12:20 +0100)
commitb39e25d808fc8922bc24d5eb8ff682817966d82b
tree51488fdd8dc02b263869ca3d2262565a06b5528a
parent13f1155bb4e4f716a1b26d38fc18c757ea538c2e
Revert "sched/wait: Suppress Sparse 'variable shadowing' warning"

This reverts commit 5e5376fac17705bf10c9ec244f5ce39bc0d55923.

This warning is actually useful, don't suppress it.

We actually rely on the shadowing for ___wait_cond_timeout().

We further used the __ret variable in __wait_event_timeout()'s cmd
argument: __ret = schedule_timeout(__ret). That now explicitly uses the
wrong __ret.

Reported-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Requested-by: Andrew Morton <akpm@linux-foundation.org>
Requested-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-Q5blhuqqzwgVwvjf1gszrdol@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/wait.h