]> git.baikalelectronics.ru Git - kernel.git/commit
Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
authorJohn Garry <john.garry@huawei.com>
Mon, 21 Dec 2020 14:30:55 +0000 (22:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Jan 2021 15:44:03 +0000 (16:44 +0100)
commitb390307d3c378cfd0c8912fbf895f9cfeea9b90a
tree1e0fe495068d0512db1b26eec822e2178c0f03e0
parentbb280e78e0368e37730b989f16ca96d4af76abf2
Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()

The current check of nvec < minvec for nvec returned from
platform_irq_count() will not detect a negative error code in nvec.

This is because minvec is unsigned, and, as such, nvec is promoted to
unsigned in that check, which will make it a huge number (if it contained
-EPROBE_DEFER).

In practice, an error should not occur in nvec for the only in-tree
user, but add a check anyway.

Fixes: 1f68dc055ac9 ("driver core: platform: Add devm_platform_get_irqs_affinity()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1608561055-231244-1-git-send-email-john.garry@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/platform.c