]> git.baikalelectronics.ru Git - kernel.git/commit
net: alteon: Simplify DMA setting
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 8 Jan 2022 14:26:06 +0000 (15:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 10 Jan 2022 00:52:18 +0000 (16:52 -0800)
commitb38df9d245e2eb02912852513d6ee9f8057bf94f
tree78b124bfb467d493cd0ab9547e7d0cec2ea0c358
parent02f4f246b4e6ccaafe0a791983cb65c11b71e5ff
net: alteon: Simplify DMA setting

As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

If dma_set_mask_and_coherent() succeeds, 'ap->pci_using_dac' is known to be
1. So 'pci_using_dac' can be removed from the 'struct ace_private'.

Simplify code and remove some dead code accordingly.

[1]: https://lkml.org/lkml/2021/6/7/398

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/1a414c05c27b21c661aef61dffe1adcd1578b1f5.1641651917.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/alteon/acenic.h