]> git.baikalelectronics.ru Git - kernel.git/commit
spi: imx: Fix failure path leak on GPIO request error
authorTrent Piepho <tpiepho@impinj.com>
Fri, 27 Oct 2017 01:08:39 +0000 (18:08 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 31 Oct 2017 11:20:23 +0000 (11:20 +0000)
commitb34a76282d8401f41942e06e7a925d16998e4cb4
tree50cdde5f72aac13d294cfb36d4b7fbfd348581fd
parent1263fa64361cd5b1c2121f9af80e06a2b628290a
spi: imx: Fix failure path leak on GPIO request error

If the code that requests any chip select GPIOs fails, the cleanup of
spi_bitbang_start() by calling spi_bitbang_stop() is not done.

Fix this by moving spi_bitbang_start() to after the code that requets
GPIOs.  The GPIOs are dev managed and don't need explicit cleanup.
Since spi_bitbang_start() is now the last operation, it doesn't need
to be cleaned up in the failure path.

CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Fabio Estevam <fabio.estevam@nxp.com>
CC: Mark Brown <broonie@kernel.org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c