]> git.baikalelectronics.ru Git - kernel.git/commit
mm/pagewalk.c: report holes in hugetlb ranges
authorJann Horn <jannh@google.com>
Tue, 14 Nov 2017 00:03:44 +0000 (01:03 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 15 Nov 2017 21:12:08 +0000 (13:12 -0800)
commitb317e0ebf3a6fd8e1d4cf8346058c57f4fbf9118
tree4dd47b260e9210d3da7bb3408d70a459f9467a59
parenta341e9810ce94681a8f1c54ac911233a7899aa31
mm/pagewalk.c: report holes in hugetlb ranges

This matters at least for the mincore syscall, which will otherwise copy
uninitialized memory from the page allocator to userspace.  It is
probably also a correctness error for /proc/$pid/pagemap, but I haven't
tested that.

Removing the `walk->hugetlb_entry` condition in walk_hugetlb_range() has
no effect because the caller already checks for that.

This only reports holes in hugetlb ranges to callers who have specified
a hugetlb_entry callback.

This issue was found using an AFL-based fuzzer.

v2:
 - don't crash on ->pte_hole==NULL (Andrew Morton)
 - add Cc stable (Andrew Morton)

Fixes: 953d725883d2 ("mincore: apply page table walker on do_mincore()")
Signed-off-by: Jann Horn <jannh@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/pagewalk.c