]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: docg3: dereferencing an ERR_PTR() in docg3_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 28 Nov 2011 13:53:13 +0000 (16:53 +0300)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 9 Jan 2012 18:07:32 +0000 (18:07 +0000)
commitb28ff1e1777de904e63c657ddbe8137de1931712
treee125dca29028b59322fe3b7bb096b4191bff0791
parent2971cf9e9008b921bdcb7010b6e5bfc194c0e4ce
mtd: docg3: dereferencing an ERR_PTR() in docg3_probe()

If doc_probe_device() returned an ERR_PTR, then we accidentally saved
that to docg3_floors[floor] = mtd; which gets derefenced in the error
handling when we call doc_release_device().

I've reworked the error handling to take care of that and hopefully
make it a little simpler.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/devices/docg3.c