]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "drm/i915: write backlight harder"
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 22 Mar 2013 14:44:46 +0000 (15:44 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 24 Mar 2013 12:23:20 +0000 (13:23 +0100)
commitb285a5939f09afeaecd384c31a1b12e410c29c56
tree459d6d08ade437bae2c95b60b5bef0fe4dbc8201
parenta76fe57f9b36654a690e600fd4c02300aa1879b1
Revert "drm/i915: write backlight harder"

This reverts commit 0ac8d4bfeec27061ee99ca18c0dbe51f4f8384cd.

Turns out that cargo-culting breaks systems. Note that we can't revert
further, since

commit 02ae6fd77749087cf17f4b18e5a4b7183a6d26da
Author: Takashi Iwai <tiwai@suse.de>
Date:   Sat Aug 11 08:56:42 2012 +0200

    drm/i915: Fix blank panel at reopening lid

fixed a regression in 3.6-rc kernels for which we've never figured out
the exact root cause. But some further inspection of the backlight
code reveals that it's seriously lacking locking. And especially the
asle backlight update is know to get fired (through some smm magic)
when writing specific backlight control registers. So the possibility
of suffering from races is rather real.

Until those races are fixed I don't think it makes sense to try
further hacks. Which sucks a bit, but sometimes that's how it is :(

References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47941
Tested-by: Takashi Iwai <tiwai@suse.de>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: stable@vger.kernel.org (the reverted commit was cc: stable, too)
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_panel.c