]> git.baikalelectronics.ru Git - kernel.git/commit
drm: meson: fix address type confusion
authorArnd Bergmann <arnd@arndb.de>
Tue, 7 Jan 2020 21:46:37 +0000 (22:46 +0100)
committerNeil Armstrong <narmstrong@baylibre.com>
Wed, 8 Jan 2020 12:51:56 +0000 (13:51 +0100)
commitb2809e2a06fc4e3e8e0a5253c34651e029ea11fb
tree794c2eed499c51f192a6e0059da8e9ce82336316
parent8b739807a1da960af863696b5628824b63b5a5eb
drm: meson: fix address type confusion

Casting a pointer to dma_addr_t produces a warning:

drivers/gpu/drm/meson/meson_rdma.c: In function 'meson_rdma_free':
drivers/gpu/drm/meson/meson_rdma.c:59:25: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  priv->rdma.addr_phys = (dma_addr_t)NULL;

In this case, it's worse because the variable name has the suffix
'_phys', which often indicates a phys_addr_t rather than dma_addr_t,
i.e. yet another incompatible type.

Change it to use consistent naming and avoid NULL.

Fixes: deb8fd083eca ("drm/meson: add RDMA module driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200107214653.1173199-1-arnd@arndb.de
drivers/gpu/drm/meson/meson_drv.h
drivers/gpu/drm/meson/meson_rdma.c