]> git.baikalelectronics.ru Git - kernel.git/commit
drm/dp_mst: Remove all evil duplicate state pointers
authorLyude Paul <lyude@redhat.com>
Tue, 23 Oct 2018 23:12:47 +0000 (19:12 -0400)
committerLyude Paul <lyude@redhat.com>
Wed, 24 Oct 2018 19:44:45 +0000 (15:44 -0400)
commitb245815936c2cad3615eabd84bf54fff7901f060
tree98e3602e78738c96ea182a1061196b571d091941
parentdd7aad555cfa8df092868e3a72e665c2df9a792d
drm/dp_mst: Remove all evil duplicate state pointers

There's no reason to track the atomic state three times. Unfortunately,
this is currently what we're doing, and even worse is that there is only
one actually correct state pointer: the one in mst_state->base.state.
mgr->state never seems to be used, along with the one in
mst_state->state.

This confused me for over 4 hours until I realized there was no magic
behind these pointers. So, let's save everyone else from the trouble.

Signed-off-by: Lyude Paul <lyude@redhat.com>.
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181023231251.16883-3-lyude@redhat.com
include/drm/drm_dp_mst_helper.h