]> git.baikalelectronics.ru Git - kernel.git/commit
lan78xx: Don't reset the interface on open
authorPhil Elwell <phil@raspberrypi.org>
Tue, 10 Apr 2018 12:18:25 +0000 (13:18 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 18:44:45 +0000 (14:44 -0400)
commitb1f7f00199a51b7b16d8dc1470347bfd984b9e50
treee31eeb252287269fc1f33d030497ddcbd3305f72
parentc30ae665e732f75eca05836ffa9667813f2d92d5
lan78xx: Don't reset the interface on open

Commit 672df5b34fdd ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.

Fix this issue by removing the lan78xx_reset call from lan78xx_open.

Fixes: 672df5b34fdd ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c