]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: qcom: apq8016_sbc: Fix oops with multiple DAI links
authorStephan Gerhold <stephan@gerhold.net>
Mon, 22 Jul 2019 13:03:52 +0000 (15:03 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 23 Jul 2019 11:16:29 +0000 (12:16 +0100)
commitb19f293e9c30218468f23e80c6821f194e4dcc17
tree78c483b107c55324164cbec33f363f19f95b9c7d
parent9ea59397637e6ed514787a0a7ae602e8fb4ca84d
ASoC: qcom: apq8016_sbc: Fix oops with multiple DAI links

apq8016_sbc_parse_of() sets up multiple DAI links, depending on the
number of nodes in the device tree. However, at the moment
CPU and platform components are only allocated for the first link.
This causes an oops when more than one link is defined:

Internal error: Oops: 96000044 [#1] SMP
CPU: 0 PID: 1015 Comm: kworker/0:2 Not tainted 5.3.0-rc1 #4
Call trace:
 apq8016_sbc_platform_probe+0x1a8/0x3f0
 platform_drv_probe+0x50/0xa0
...

Move the allocation inside the loop to ensure that each link is
properly initialized.

Fixes: 0a3816483628 ("ASoC: qcom: apq8016_sbc: use modern dai_link style")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20190722130352.95874-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/apq8016_sbc.c