]> git.baikalelectronics.ru Git - kernel.git/commit
[media] vivid: move PRINTSTR to separate functions
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 5 Jun 2015 16:09:31 +0000 (13:09 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 6 Jun 2015 01:22:05 +0000 (22:22 -0300)
commitb17157880887aa39c5863bf8f3847f949869d75d
treeebe90ed1a3247fa9ea022f4c11da342b41e07517
parent6259daedb047534d798850550a2939f9dec32199
[media] vivid: move PRINTSTR to separate functions

Commit df4ae30391cb6def31564f7f730c91458495020a broke vivid-tpg
(uninitialized variable p).

This patch takes a different approach: four different functions are
created, one for each PRINTSTR version.

In order to avoid the 'the frame size of 1308 bytes is larger than 1024
bytes' warning I had to mark those functions with 'noinline'. For
whatever reason gcc seems to inline this aggressively and it is doing
weird things with the stack.

I tried to read the assembly code, but I couldn't see what exactly it
was doing on the stack.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/vivid/vivid-tpg.c