]> git.baikalelectronics.ru Git - kernel.git/commit
auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 23 Feb 2022 15:47:16 +0000 (17:47 +0200)
committerMiguel Ojeda <ojeda@kernel.org>
Wed, 2 Mar 2022 23:29:26 +0000 (00:29 +0100)
commitb128f55c75b76e270d7c597a7dbff27f46572992
tree41f63a799f36ad5d2b62dda71626bed16207bc13
parenta4bb3615af56325e357eba8358c36083800642a8
auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature

It seems that the lcd2s_redefine_char() has never been properly
tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
by the character number (from 0 to 7), but immediately after that
these bytes are rewritten by the decoded hex stream.

Fix the index to fill the buffer after the command and number.

Fixes: d4bab42e94cd ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
[fixed typo in commit message]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
drivers/auxdisplay/lcd2s.c