]> git.baikalelectronics.ru Git - kernel.git/commit
[media] imon: fix Knob event interpretation issues on ARM
authorAlexandre Lissy <alexandrelissy@free.fr>
Sun, 2 Sep 2012 18:35:20 +0000 (15:35 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 1 Feb 2013 09:13:59 +0000 (07:13 -0200)
commitb0c96621ba5415db35e40603a7392a4ed10f515c
tree16accd08e370abf4de504ebbb4d12319dc7e6b7e
parent4ea239a2b8134d375b8219bdec42110472703e51
[media] imon: fix Knob event interpretation issues on ARM

Events for the iMon Knob pad where not correctly interpreted on ARM,
resulting in buggy mouse movements (cursor going straight out of the
screen), key pad only generating KEY_RIGHT and KEY_DOWN events.
A reproducer is:
int main(int argc, char ** argv)
{
        char rel_x = 0x00; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
        rel_x = 0x0f; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
        rel_x |= ~0x0f; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
        return 0;
}
(running on x86 or amd64)
$ ./test
rel_x:0 @test.c:6
rel_x:15 @test.c:7
rel_x:-1 @test.c:8
(running on armv6)
rel_x:0 @test.c:6
rel_x:15 @test.c:7
rel_x:255 @test.c:8
Forcing the rel_x and rel_y variables as signed char fixes the issue.

Reference: http://www.arm.linux.org.uk/docs/faqs/signedchar.php

Signed-off-by: Alexandre Lissy <alexandrelissy@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/imon.c