]> git.baikalelectronics.ru Git - kernel.git/commit
dlm: free workqueues after the connections
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Sat, 8 Oct 2016 13:14:37 +0000 (10:14 -0300)
committerDavid Teigland <teigland@redhat.com>
Mon, 10 Oct 2016 14:54:00 +0000 (09:54 -0500)
commitb086fee5c2b81599641848144cac5e04e4e362cf
treee4395e493ec475bbcb9402e647e9429b56be3db3
parent465d54c334eb2249c3dde733f1b0d01221df9f71
dlm: free workqueues after the connections

After backporting commit a7af23a47fe7 ("dlm: use sctp 1-to-1 API")
series to a kernel with an older workqueue which didn't use RCU yet, it
was noticed that we are freeing the workqueues in dlm_lowcomms_stop()
too early as free_conn() will try to access that memory for canceling
the queued works if any.

This issue was introduced by commit 7a8e1bd34a55 as before it such
attempt to cancel the queued works wasn't performed, so the issue was
not present.

This patch fixes it by simply inverting the free order.

Cc: stable@vger.kernel.org
Fixes: 7a8e1bd34a55 ("dlm: fix race while closing connections")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lowcomms.c