]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: arm/arm64: vgic: Stop injecting the MSI occurrence twice
authorShanker Donthineni <shankerd@codeaurora.org>
Fri, 3 Feb 2017 02:30:03 +0000 (20:30 -0600)
committerMarc Zyngier <marc.zyngier@arm.com>
Wed, 8 Feb 2017 15:13:14 +0000 (15:13 +0000)
commitb062df3ee9b01fee23191e0d82acabd6e54f151f
tree7779937b27f194a5d9ad93fb713209e4dc28acfb
parent0a3e8a234b3f15fc1fe981c1638f057f66114455
KVM: arm/arm64: vgic: Stop injecting the MSI occurrence twice

The IRQFD framework calls the architecture dependent function
twice if the corresponding GSI type is edge triggered. For ARM,
the function kvm_set_msi() is getting called twice whenever the
IRQFD receives the event signal. The rest of the code path is
trying to inject the MSI without any validation checks. No need
to call the function vgic_its_inject_msi() second time to avoid
an unnecessary overhead in IRQ queue logic. It also avoids the
possibility of VM seeing the MSI twice.

Simple fix, return -1 if the argument 'level' value is zero.

Cc: stable@vger.kernel.org
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
virt/kvm/arm/vgic/vgic-irqfd.c