]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: There is only one fault register from GEN8 onwards
authorMichel Thierry <michel.thierry@intel.com>
Mon, 13 Nov 2017 17:36:28 +0000 (09:36 -0800)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 13 Nov 2017 19:04:32 +0000 (19:04 +0000)
commitb03ec3d67ab840f674eb61a3467fd971c9552aa4
treed350572b5f5e987eb3238acb6535b3cc88e6a6bd
parentce453b3e426f33eb56e5425f0b839f75eed621d9
drm/i915: There is only one fault register from GEN8 onwards

Until Haswell/Baytrail, the hardware used to have a per engine fault
register (e.g. 0x4094 - render fault register, 0x4194 - media fault
register and so on). But since Broadwell, all these registers were
combined into a singe one and the engine id stored in bits 14:12.

Not only we should not been reading (and writing to) registers that do
not exist, in platforms with VCS2 (SKL), the address that would belong
this engine (0x4494, VCS2_HW = 4) is already assigned to other register.

v2: use less controversial function names (Chris).
v3: make non-exported functions static, remove now obsolete check for
engine presence before posting_read (Chris).

References: IHD-OS-BDW-Vol 2c-11.15, page 75.
References: IHD-OS-SKL-Vol 2c-05.16, page 350.
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20171113173628.11689-1-michel.thierry@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_gem_gtt.c
drivers/gpu/drm/i915/i915_gpu_error.c
drivers/gpu/drm/i915/i915_reg.h