]> git.baikalelectronics.ru Git - kernel.git/commit
perf evlist: Fix missing event name init for default event
authorStephane Eranian <eranian@google.com>
Tue, 7 Jun 2011 16:19:36 +0000 (18:19 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 18 Aug 2011 10:20:31 +0000 (07:20 -0300)
commitaf7ab141687c30ec082a3bd7eda27b102bbded40
treea6111ef0349b82b982a504f633c0d820f0c95ae7
parentffa415ad9cc2c65c93e5ceccc409edc137a6b811
perf evlist: Fix missing event name init for default event

When no event is given to perf record, perf top, a default event is
initialized (cycles). However, perf_evlist__add_default() was not
setting the symbolic name for the event. Perf top worked simply because
it was reconstructing the name from the event code. But it should not
have to do this. This patch initializes the evsel->name field properly.

This second version improves the code flow on the non error path.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20110607161936.GA8163@quad
Signed-off-by: Stephane Eranian <eranian@google.com>
[committer note: Use perf_evsel__delete() instead of plain free()]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evlist.c