]> git.baikalelectronics.ru Git - kernel.git/commit
xen: correctly check for pending events when restoring irq flags
authorDavid Vrabel <david.vrabel@citrix.com>
Thu, 26 Apr 2012 18:44:06 +0000 (19:44 +0100)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Fri, 27 Apr 2012 20:04:21 +0000 (16:04 -0400)
commitaf321e3ccaefa01df8b05093ecb67ae774eab8d8
treef04b92fc472ca0d41ae5eb61daff6748789cd747
parent35f3531b0d67f37bfe9ed4f7dace3fe2be7ae663
xen: correctly check for pending events when restoring irq flags

In xen_restore_fl_direct(), xen_force_evtchn_callback() was being
called even if no events were pending.  This resulted in (depending on
workload) about a 100 times as many xen_version hypercalls as
necessary.

Fix this by correcting the sense of the conditional jump.

This seems to give a significant performance benefit for some
workloads.

There is some subtle tricksy "..since the check here is trying to
check both pending and masked in a single cmpw, but I think this is
correct. It will call check_events now only when the combined
mask+pending word is 0x0001 (aka unmasked, pending)." (Ian)

CC: stable@kernel.org
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
arch/x86/xen/xen-asm.S