]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86"
authorIngo Molnar <mingo@kernel.org>
Sun, 10 Jul 2016 18:58:36 +0000 (20:58 +0200)
committerIngo Molnar <mingo@kernel.org>
Sun, 10 Jul 2016 18:58:36 +0000 (20:58 +0200)
commitae58bec8eda3055c548415e3d1a789be0004caf0
treef1b2a9d46904fd3479c320267691ee89d172b3dc
parented20b7088fa6021b8cbfd06046a6d28aaaf5e061
Revert "perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86"

This reverts commit 4422ec0df21801afbb88ff93b2573de76cf25cb9.

Stephane reported the following regression:

 > Since Andi added:
 >
 > commit 4422ec0df21801afbb88ff93b2573de76cf25cb9
 > Author: Andi Kleen <ak@linux.intel.com>
 > Date:   Thu Jun 9 06:14:38 2016 -0700
 >
 >    perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86
 >
 > $ perf stat -e ref-cycles ls
 >   <not counted> ....
 >
 > fails systematically because the ref-cycles is now used by the
 > watchdog and given this is a system-wide pinned event, it monopolizes
 > the fixed counter 2 which is the only counter able to measure this event.

Since the next merge window is near, fix the regression for now
by reverting the commit.

Reported-by: Stephane Eranian <eranian@google.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/apic/hw_nmi.c
include/linux/nmi.h
kernel/watchdog.c