]> git.baikalelectronics.ru Git - kernel.git/commit
drm/atomic-helpers: Make encoder picking more robust
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 3 Aug 2015 15:24:11 +0000 (17:24 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 4 Aug 2015 09:10:41 +0000 (11:10 +0200)
commitae37a156b53458dd79bc556bc3e23975021b28e4
treee6b5c9c487f5134e63b981308079e9614b7bdd6a
parentd8837b2a996c1cb9fca13c74b17fbfa93f1efa95
drm/atomic-helpers: Make encoder picking more robust

We've had a few issues with atomic where subtle bugs in the encoder
picking logic lead to accidental self-stealing of the encoder,
resulting in a NULL connector_state->crtc in update_connector_routing
and subsequent.

Linus applied some duct-tape for an mst regression in

commit 89fa4107e34055964277b3c04e3839690e9e8b28
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed Jul 29 22:18:16 2015 -0700

    i915: temporary fix for DP MST docking station NULL pointer dereference

But that was incomplete (the code will still oops when debuggin is
enabled) and mangled the state even further. So instead WARN and bail
out as the more future-proof option.

Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_atomic_helper.c