]> git.baikalelectronics.ru Git - kernel.git/commit
netlink: fix locking around NETLINK_LIST_MEMBERSHIPS
authorDavid Herrmann <dh.herrmann@gmail.com>
Wed, 21 Oct 2015 09:47:43 +0000 (11:47 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Oct 2015 14:18:28 +0000 (07:18 -0700)
commitae299a219e5754cc576ecd10832d63bcb68ba09d
tree864eabcb29d69af1397290e7ffa926207eee01ff
parentc6ff47d6a9815c4c0bc5df1f4f942f755c2053f5
netlink: fix locking around NETLINK_LIST_MEMBERSHIPS

Currently, NETLINK_LIST_MEMBERSHIPS grabs the netlink table while copying
the membership state to user-space. However, grabing the netlink table is
effectively a write_lock_irq(), and as such we should not be triggering
page-faults in the critical section.

This can be easily reproduced by the following snippet:
    int s = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
    void *p = mmap(0, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 0);
    int r = getsockopt(s, 0x10e, 9, p, (void*)((char*)p + 4092));

This should work just fine, but currently triggers EFAULT and a possible
WARN_ON below handle_mm_fault().

Fix this by reducing locking of NETLINK_LIST_MEMBERSHIPS to a read-side
lock. The write-lock was overkill in the first place, and the read-lock
allows page-faults just fine.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c