]> git.baikalelectronics.ru Git - kernel.git/commit
HID: rmi: fix some harmless BIT() mistakes
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 May 2015 08:32:56 +0000 (11:32 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 18 May 2015 09:22:53 +0000 (11:22 +0200)
commitae154aaf8f593989fcd891a563a016e0f4fc235b
tree04b01b156f190db2f87cb3656c1e1edde633818f
parentcc552d2dbd26bf23488b68eeede139dd975e021d
HID: rmi: fix some harmless BIT() mistakes

These defines are used like this:

if (!(test_bit(RMI_STARTED, &hdata->flags)))

So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4.  It's harmless because it's done
consistently but static checkers will complain.

Fixes: f21884b15b5d ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-rmi.c