]> git.baikalelectronics.ru Git - kernel.git/commit
drm: sun4i: hdmi: Remove extra HPD polling
authorChen-Yu Tsai <wens@csie.org>
Mon, 29 Jun 2020 06:00:32 +0000 (14:00 +0800)
committerMaxime Ripard <maxime@cerno.tech>
Tue, 30 Jun 2020 08:01:48 +0000 (10:01 +0200)
commitae066a51c66aa2f5d764396e7f070a0fd1140e78
treee7bb291d1405e515156a31ed70bd0093f19e4b7c
parent4cc449ea3dc748f39478dc8542b2cc2fde4720f9
drm: sun4i: hdmi: Remove extra HPD polling

The HPD sense mechanism in Allwinner's old HDMI encoder hardware is more
or less an input-only GPIO. Other GPIO-based HPD implementations
directly return the current state, instead of polling for a specific
state and returning the other if that times out.

Remove the I/O polling from sun4i_hdmi_connector_detect() and directly
return a known state based on the current reading. This also gets rid
of excessive CPU usage by kworker as reported on Stack Exchange [1] and
Armbian forums [2].

 [1] https://superuser.com/questions/1515001/debian-10-buster-on-cubietruck-with-bug-in-sun4i-drm-hdmi
 [2] https://forum.armbian.com/topic/14282-headless-systems-and-sun4i_drm_hdmi-a10a20/

Fixes: fae50b4cec20 ("drm/sun4i: Add HDMI support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20200629060032.24134-1-wens@kernel.org
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c