]> git.baikalelectronics.ru Git - kernel.git/commit
RDMA/core: Fix incorrect structure packing for booleans
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Fri, 23 Dec 2016 01:07:52 +0000 (18:07 -0700)
committerDoug Ledford <dledford@redhat.com>
Thu, 12 Jan 2017 17:21:51 +0000 (12:21 -0500)
commitade18d04592587e66e10074c6bfe19ac6e821ce4
treef877be5cf0ad56274e3bc637e37cf6171a0595b4
parent0e4562ac0ff161d355f1456ceb61dc32aea51dbd
RDMA/core: Fix incorrect structure packing for booleans

The RDMA core uses ib_pack() to convert from unpacked CPU structs
to on-the-wire bitpacked structs.

This process requires that 1 bit fields are declared as u8 in the
unpacked struct, otherwise the packing process does not read the
value properly and the packed result is wired to 0. Several
places wrongly used int.

Crucially this means the kernel has never, set reversible
correctly in the path record request. It has always asked for
irreversible paths even if the ULP requests otherwise.

When the kernel is used with a SM that supports this feature, it
completely breaks communication management if reversible paths are
not properly requested.

The only reason this ever worked is because opensm ignores the
reversible bit.

Cc: stable@vger.kernel.org
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
include/rdma/ib_sa.h