]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: eliminate 'temp' in gen8_for_each_{pdd, pdpe, pml4e} macros
authorDave Gordon <david.s.gordon@intel.com>
Tue, 8 Dec 2015 13:30:51 +0000 (13:30 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 10 Dec 2015 08:36:42 +0000 (09:36 +0100)
commitad21740ddf944ffdc62d591a9e84094a2f3ee677
treef4a3f5581fe7b5228e961f67bac56a09b2978550
parent50ed3066cafea471110dc18c25dd280886a9b03d
drm/i915: eliminate 'temp' in gen8_for_each_{pdd, pdpe, pml4e} macros

All of these iterator macros require a 'temp' argument, used merely to
hold internal partial results. We can instead declare the temporary
variable inside the macro, so the caller need not provide it.

Some of the old code contained nested iterators that actually reused the
same 'temp' variable for both inner and outer instances. It's quite
surprising that this didn't introduce bugs! But it does show that the
value of 'temp' isn't required to persist during the iterated body.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1449581451-11848-2-git-send-email-david.s.gordon@intel.com
drivers/gpu/drm/i915/i915_gem_gtt.c
drivers/gpu/drm/i915/i915_gem_gtt.h