]> git.baikalelectronics.ru Git - kernel.git/commit
kfifo: fix kfifo_to_user() return type
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 24 Jun 2022 05:30:04 +0000 (08:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:08 +0000 (14:24 +0200)
commitace38563a3257f36673aed22ff99fe03e80682fc
tree1bf4c1ef311384dca2db18eecf5b52648ac1ee1a
parent0783592e04b3972bf7aa4b82be868842a07699b0
kfifo: fix kfifo_to_user() return type

[ Upstream commit 773ac7caabcbbae504658d302e2d268817b2147d ]

The kfifo_to_user() macro is supposed to return zero for success or
negative error codes.  Unfortunately, there is a signedness bug so it
returns unsigned int.  This only affects callers which try to save the
result in ssize_t and as far as I can see the only place which does that
is line6_hwdep_read().

TL;DR: s/_uint/_int/.

Link: https://lkml.kernel.org/r/YrVL3OJVLlNhIMFs@kili
Fixes: 77b8f66938e3 ("kfifo: fix kfifo_alloc() to return a signed int value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/kfifo.h