]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Move the PIPEMISC write the correct place
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 2 May 2019 20:06:06 +0000 (23:06 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 3 May 2019 16:22:33 +0000 (19:22 +0300)
commitac6c039cc45959959c6dddb5997c5642ec7da5e2
tree999c41c70e3120acd2e76b2427d99e686a200ad8
parent0f4363be085cbaf037957b0829f57a1e181cd79c
drm/i915: Move the PIPEMISC write the correct place

I fumbled the PIPEMISC write into the wrong place. It only gets
called for fastsets, but since value needs to be updated based on
the set of active planes it needs to be done for all plane updates.
Move it to the correct spot.

The symptoms include SDR planes never showing up if a previous
modeset/fastset left the pipe in HDR mode. This was immediately
obvious when running the kms_plane pixel format tests. Unfortunately
the test didn't realize it was scanning out pure black all the time
and declared success anyway.

Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Fixes: 86154fe3da3f ("drm/i915: Enable pipe HDR mode on ICL if only HDR planes are used")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190502200607.14504-1-ville.syrjala@linux.intel.com
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
drivers/gpu/drm/i915/intel_display.c