]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ACPI: ignore FADT reset-reg-sup flag"
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 20 Apr 2012 18:19:35 +0000 (11:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 20 Apr 2012 18:19:35 +0000 (11:19 -0700)
commitac21e29b3d3a3cec33e6705140fe180707709630
tree5ebe6d43bd493f61492ff92fe957c7a44418fa8f
parente7c67fc00fc3ee23e577d26506e5d729cbafd9ff
Revert "ACPI: ignore FADT reset-reg-sup flag"

This reverts commit 9df76d389dfb19e4cef624e32bd772f982ac6a98.

It breaks reboot on at least one Thinkpad T43, as reported by Jörg Otte:
 "On reboot it shuts down as normal.
  The last lines displayed are:

  >Unmounting temporary filesystems.. [OK]
  >Deactivating swap...               [OK]
  >Unmounting local filesystems...    [OK]
  >Will now restart
  >    Restarting system

  Then I hear it accessing the cd-drive, but then it's being stuck."

Jörg bisected the regression to this commit.

That commit fixes another machine (see

  https://bugzilla.kernel.org/show_bug.cgi?id=11533

for details) that has a BIOS bug and doesn't support ACPI reset.
However, at least one of those other reporters no longer even has the
machine in question, and had a different workaround to begin with.
Besides, it clearly was a buggy BIOS.  Let's not break the correct case
to fix that case.

Reported-and-bisected-by: Jörg Otte <jrg.otte@googlemail.com>
Cc: linux-acpi@vger.kernel.org
Cc: Len Brown <lenb@kernel.org>
Cc: Peter Anvin <hpa@zytor.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/acpi/acpica/hwxface.c
drivers/acpi/reboot.c