]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "[PATCH] binfmt_elf: randomize PIE binaries (2nd try)"
authorLinus Torvalds <torvalds@woody.osdl.org>
Sat, 6 Jan 2007 21:28:21 +0000 (13:28 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Sat, 6 Jan 2007 21:28:21 +0000 (13:28 -0800)
commitabad407dddce4e7e609cbf0711dd224aa89de3eb
treea512f783a9dec262fbff98ff608411d1afd87f97
parent01c9011d0e845e1ac6bae9539a6c8a2e428568fa
Revert "[PATCH] binfmt_elf: randomize PIE binaries (2nd try)"

This reverts commit 4ebff8a2d863f37c3f07665e065212b74b4c9f59.

Hugh Dickins reports that it causes random failures on x86 with SuSE
10.2, and points out

  "Isn't that randomization, anywhere from 0x10000 to ELF_ET_DYN_BASE,
   sure to place the ET_DYN from time to time just where the comment
   says it's trying to avoid? I assume that somehow results in the error
   reported."

(where the comment in question is the existing comment in the source
code about mmap/brk clashes).

Suggested-by: Hugh Dickins <hugh@veritas.com>
Acked-by: Marcus Meissner <meissner@suse.de>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/binfmt_elf.c